From 84523ef4305b2d3cadb6e613939462a21f9f6f38 Mon Sep 17 00:00:00 2001 From: Ryan Cao <70191398+ryanccn@users.noreply.github.com> Date: Mon, 13 Nov 2023 20:31:46 +0800 Subject: [PATCH] refactor to use `sort_by_key` and `reverse` Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com> --- src/remote_node_index.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/remote_node_index.rs b/src/remote_node_index.rs index ac5974f..6eb3259 100644 --- a/src/remote_node_index.rs +++ b/src/remote_node_index.rs @@ -89,10 +89,9 @@ pub fn list( let resp = crate::http::get(&index_json_url)?; let mut value: Vec = resp.json()?; - if *sort == SortingMethod::Ascending { - value.sort_by(|a, b| a.version.cmp(&b.version)); - } else { - value.sort_by(|a, b| b.version.cmp(&a.version)); + value.sort_by_key(|v| v.version.clone()); + if let SortingMethod::Descending = sort { + value.reverse(); } Ok(value)