alvis/fnm - fnm - Gitea: Git with a cup of tea

128 Commits

1 Branch

66 Tags

4.3 MiB

Tree: 7dd568475d

Commit Graph

Author	SHA1	Message	Date
Gal Schlezinger	7dd568475d	Fix "illegal instruction" errors on some CPUs (#177 ) This is done by pinning gmp to a fork of `esy-packages/esy-gmp` that uses the `--enable-fat` argument, suggested by @ulrikstrid. Here's the description of the open PR for `esy-packages/esy-gmp` https://github.com/esy-packages/esy-gmp/pull/3: > GMP uses [Intel ADX](https://en.wikipedia.org/wiki/Intel_ADX) to do math stuff when capable for performance reasons. The pick whether to use ADX or not is being chosen on compile time, unless you specify `--enable-fat` which creates a "fat" binary that decides on runtime whether to use these custom instructions: > > > Using --enable-fat selects a “fat binary” build on x86, where optimized low level subroutines are chosen at runtime according to the CPU detected. This means more code, but gives good performance on all x86 chips. (This option might become available for more architectures in the future.) > > Without this flag, users can get "illegal hardware instruction" errors when running their binaries on a machine without Intel ADX. > > So, in other words, this PR enables building gmp into a binary on CI which _has Intel ADX_, and then using it on a machine that does not have it (like AMD or older Intels) > > To me, it sounds like a sane default.	5 years ago

Author

SHA1

Message

Date

Gal Schlezinger

7dd568475d

Fix "illegal instruction" errors on some CPUs (#177 )

This is done by pinning gmp to a fork of `esy-packages/esy-gmp` that uses the `--enable-fat` argument, suggested by @ulrikstrid.

Here's the description of the open PR for `esy-packages/esy-gmp` https://github.com/esy-packages/esy-gmp/pull/3:

> GMP uses [Intel ADX](https://en.wikipedia.org/wiki/Intel_ADX) to do math stuff when capable for performance reasons. The pick whether to use ADX or not is being chosen on compile time, unless you specify `--enable-fat` which creates a "fat" binary that decides on runtime whether to use these custom instructions:
> 
> > Using --enable-fat selects a “fat binary” build on x86, where optimized low level subroutines are chosen at runtime according to the CPU detected. This means more code, but gives good performance on all x86 chips. (This option might become available for more architectures in the future.)
> 
> Without this flag, users can get "illegal hardware instruction" errors when running their binaries on a machine without Intel ADX.
> 
> So, in other words, this PR enables building gmp into a binary on CI which _has Intel ADX_, and then using it on a machine that does not have it (like AMD or older Intels)
> 
> To me, it sounds like a sane default.

5 years ago

1 Commits (7dd568475dfb0b57b2636256698dc0ef59630659)