Browse Source

[New] `nvm install`: Print the version that is being installed

Peter Dave Hello 8 years ago committed by Jordan Harband
parent
commit
9c92b5a4ea
No known key found for this signature in database
GPG Key ID: 64A196AEE0916D55
  1. 5
      nvm.sh
  2. 2
      test/installation_node/install hook

5
nvm.sh

@ -1581,6 +1581,11 @@ nvm_install_binary() { @@ -1581,6 +1581,11 @@ nvm_install_binary() {
local TMPDIR
local VERSION_PATH
local NODE_OR_IOJS
if [ "${FLAVOR}" = 'node' ]; then
NODE_OR_IOJS="${FLAVOR}"
fi
nvm_echo "Downloading and installing ${NODE_OR_IOJS-} ${VERSION}..."
TARBALL="$(nvm_download_artifact "${FLAVOR}" binary "${TYPE-}" "${VERSION}" | command tail -1)"
if [ -f "${TARBALL}" ]; then
TMPDIR="$(dirname "${TARBALL}")/files"

2
test/installation_node/install hook

@ -22,6 +22,7 @@ fail() { @@ -22,6 +22,7 @@ fail() {
OUTPUT="$(NVM_INSTALL_THIRD_PARTY_HOOK=succeed nvm install "${VERSION}")"
USE_OUTPUT="$(nvm use "${VERSION}")"
EXPECTED_OUTPUT="${VERSION} node std binary ${VERSION_PATH}
Downloading and installing node ${VERSION}...
${USE_OUTPUT}
${USE_OUTPUT}" # double use output is from the normal install in succeed()
@ -32,6 +33,7 @@ ${USE_OUTPUT}" # double use output is from the normal install in succeed() @@ -32,6 +33,7 @@ ${USE_OUTPUT}" # double use output is from the normal install in succeed()
OUTPUT="$(NVM_INSTALL_THIRD_PARTY_HOOK=fail nvm install "${VERSION}" || echo 'failed')"
USE_OUTPUT="$(nvm use "${VERSION}")"
EXPECTED_OUTPUT="${VERSION} node std binary ${VERSION_PATH}
Downloading and installing node ${VERSION}...
${USE_OUTPUT}
failed"

Loading…
Cancel
Save