Fix version inference by throwing on http 404 again (#69)

Also, make all tests fail on errors

feature_tests/basic/run.sh

@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -e
+
 eval $(fnm env)
 fnm install v8.11.3
 fnm use v8.11.3

feature_tests/existing_installation/run.sh

@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -e
+
 eval `fnm env`
 
 echo "> Installing for the first time..."

feature_tests/matching-dotfiles/run.sh

@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -e
+
 eval $(fnm env)
 fnm install
 fnm use

feature_tests/node-version/run.sh

@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -e
+
 eval $(fnm env)
 fnm install
 fnm use

feature_tests/node_mirror_installation/run.sh

@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -e
+
 eval `fnm env --node-dist-mirror="https://cnpmjs.org/dist"`
 
 fnm install v8.11.3

feature_tests/nvmrc/run.sh

@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -e
+
 eval $(fnm env)
 fnm install
 fnm use

feature_tests/partial_semver/run.sh

@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -e
+
 eval `fnm env --multi`
 
 fnm install 6 # no new versions would be issued for this unsupported version

library/Http.re

@@ -11,9 +11,12 @@ type response = {
 let body = response => response.body;
 let status = response => response.status;
 
-exception Unknown_status_code(int, response);
 exception Not_found(response);
-exception Internal_server_error(response);
+
+let throwOnKnownErrors =
+  fun
+  | {status: 404} as r => Lwt.fail(Not_found(r))
+  | r => Lwt.return(r);
 
 let rec makeRequest = url =>
   Uri.of_string(url)
@@ -28,7 +31,7 @@ let rec makeRequest = url =>
       | (true, Some(uri)) => makeRequest(Uri.to_string(uri))
       | _ =>
         let%lwt body = body |> Cohttp_lwt.Body.to_string;
-        Lwt.return({status: code_of_status, body});
+        throwOnKnownErrors({status: code_of_status, body});
       };
     }
   );

library/Versions.re

@@ -221,6 +221,7 @@ let getRemoteLatestVersionByPrefix = prefix => {
   open Lwt;
 
   let%lwt remoteVersions = getRemoteVersions();
+
   let compatibleVersions =
     remoteVersions
     |> List.map(x => x.name)