Browse Source

sort upon installation

remotes/origin/list-filter
Gal Schlezinger 9 months ago
parent
commit
769b96e688
  1. 11
      src/commands/install.rs

11
src/commands/install.rs

@ -95,8 +95,10 @@ impl Command for Install {
picked_version picked_version
} }
UserVersion::Full(Version::Latest) => { UserVersion::Full(Version::Latest) => {
let available_versions: Vec<_> = remote_node_index::list(&config.node_dist_mirror) let mut available_versions: Vec<_> =
remote_node_index::list(&config.node_dist_mirror)
.map_err(|source| Error::CantListRemoteVersions { source })?; .map_err(|source| Error::CantListRemoteVersions { source })?;
available_versions.sort_by(|a, b| a.version.cmp(&b.version));
let picked_version = available_versions let picked_version = available_versions
.last() .last()
.ok_or(Error::CantFindLatest)? .ok_or(Error::CantFindLatest)?
@ -256,8 +258,8 @@ mod tests {
#[test] #[test]
fn test_install_latest() { fn test_install_latest() {
let base_dir = tempfile::tempdir().unwrap(); let base_dir = std::path::PathBuf::from("/tmp/test123");
let config = FnmConfig::default().with_base_dir(Some(base_dir.path().to_path_buf())); let config = FnmConfig::default().with_base_dir(Some(base_dir.to_path_buf()));
Install { Install {
version: None, version: None,
@ -268,8 +270,9 @@ mod tests {
.apply(&config) .apply(&config)
.expect("Can't install"); .expect("Can't install");
let available_versions: Vec<_> = let mut available_versions: Vec<_> =
remote_node_index::list(&config.node_dist_mirror).expect("Can't get node version list"); remote_node_index::list(&config.node_dist_mirror).expect("Can't get node version list");
available_versions.sort_by(|a, b| a.version.cmp(&b.version));
let latest_version = available_versions.last().unwrap().version.clone(); let latest_version = available_versions.last().unwrap().version.clone();
assert!(config.installations_dir().exists()); assert!(config.installations_dir().exists());

Loading…
Cancel
Save